Possible inconsistency in HW2 SearchAll tests?

Possible inconsistency in HW2 SearchAll tests?

par Dávid Márk Valaczkai,
Number of replies: 1

I'm looking at the case when the filename has a match in the NamingStore, but the corresponding metahash isn't present in the BlobStore.

// 2-16
//
// Given the following topology
// A <-> B
// B has some entries in the name storage, but not the corresponding metahash in
// the blob store. So it should not return anything.
func Test_HW2_SearchAll_Remote_Empty(t *testing.T) {
According to this description, in this case we shouldn't return any matches. However, the SearchAll_Local test does not specify this criterium and 
indeed does not place any metahashes in the blob store either, but expects all filenames to match on the local peer.

I feel like this inconsistency is unjustified.

In reply to Dávid Márk Valaczkai

Re: Possible inconsistency in HW2 SearchAll tests?

par Yuchen Qian,
Sorry for the late reply. The SearchAll function merges both the peer's local
naming store and the filenames from all of the SearchReplyMessage. The
Test_HW2_SearchAll_Local is testing the case for local naming store.

Have a nice evening :)