Lock passed by value

Lock passed by value

by Jinyi Xian -
Number of replies: 2

I get a warning from the compiler for line 3167 of gossiper_test.go saying

getPs passes lock by value: go.dedis.ch/cs438/hw2/gossip.history

I think this may be a mistake.

In reply to Jinyi Xian

Re: Lock passed by value

by Kirill Nikitin -


Hmm yes we should probably have used a pointer there to pass the struct. But I think it should not cause any issues for the tests. Do you get any problems with running the tests because of it?